Skip to content

[FC-0099] fix: add constants and improve test class#125

Merged
mariajgrimaldi merged 4 commits intoopenedx:mainfrom
eduNEXT:mfmz/fix-constants-and-test-class
Oct 29, 2025
Merged

[FC-0099] fix: add constants and improve test class#125
mariajgrimaldi merged 4 commits intoopenedx:mainfrom
eduNEXT:mfmz/fix-constants-and-test-class

Conversation

@MaferMazu
Copy link
Copy Markdown
Contributor

@MaferMazu MaferMazu commented Oct 28, 2025 •
edited
Loading

Description

This PR:

  • Modify the BaseRolesTestCase to be able to access the policy and the model from outside.
  • Adds the roles and permissions by default as a constant for the app and not only for the tests, to be able to use it from outside.

How to test

Tests are passing.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Oct 28, 2025

Thanks for the pull request, @MaferMazu!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 28, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 28, 2025
@MaferMazu MaferMazu force-pushed the mfmz/fix-constants-and-test-class branch from f5d8f80 to 3b0b1ed Compare October 28, 2025 17:21
@MaferMazu MaferMazu self-assigned this Oct 28, 2025
@MaferMazu MaferMazu force-pushed the mfmz/fix-constants-and-test-class branch from 3b0b1ed to 2ba9672 Compare October 28, 2025 17:27
@MaferMazu MaferMazu added the release blocker Blocks the upcoming release (fix needed) label Oct 28, 2025
@MaferMazu MaferMazu moved this to Ready for review in RBAC AuthZ Board Oct 28, 2025
BryanttV
BryanttV suggested changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaferMazu!

Could we use these constants in the API views? and I'm not sure if also we should use them in the tests instead of a hardcoded string. What do you think?

@MaferMazu MaferMazu force-pushed the mfmz/fix-constants-and-test-class branch from cc84825 to 09cb1f3 Compare October 28, 2025 18:16
@MaferMazu MaferMazu requested a review from BryanttV October 28, 2025 18:17
@MaferMazu MaferMazu force-pushed the mfmz/fix-constants-and-test-class branch from 09cb1f3 to 95de071 Compare October 28, 2025 18:18
@MaferMazu MaferMazu force-pushed the mfmz/fix-constants-and-test-class branch from 95de071 to ca8e569 Compare October 28, 2025 18:24
@MaferMazu MaferMazu force-pushed the mfmz/fix-constants-and-test-class branch from ca8e569 to 1371d5e Compare October 28, 2025 18:29
@MaferMazu
Copy link
Copy Markdown
Contributor Author

MaferMazu commented Oct 28, 2025 •
edited
Loading

@BryanttV done! I changed the main string calls to /permissions and /roles constants. 7a44fa1

@MaferMazu MaferMazu mentioned this pull request Oct 28, 2025
Merged
mariajgrimaldi
mariajgrimaldi reviewed Oct 28, 2025
View reviewed changes
Comment thread openedx_authz/constants/roles.py Outdated
bmtcril
bmtcril approved these changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just a small non-blocking comment

Comment thread openedx_authz/constants/roles.py Outdated
rodmgwgu
rodmgwgu approved these changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rodmgwgu rodmgwgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the constants.

BryanttV
BryanttV approved these changes Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mariajgrimaldi
mariajgrimaldi approved these changes Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing all of my comments :)

@mariajgrimaldi mariajgrimaldi merged commit d1b0f30 into openedx:main Oct 29, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Oct 29, 2025
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in RBAC AuthZ Board Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

@bmtcril bmtcril bmtcril approved these changes

@rodmgwgu rodmgwgu rodmgwgu approved these changes

+1 more reviewer

@BryanttV BryanttV BryanttV approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MaferMazu MaferMazu

Labels

open-source-contribution PR author is not from Axim or 2U release blocker Blocks the upcoming release (fix needed)

Projects

Contributions
Archived in project
RBAC AuthZ Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MaferMazu @openedx-webhooks @BryanttV @mariajgrimaldi @bmtcril @rodmgwgu